Open
Conversation
pionbot
force-pushed
the
fix_packets_lost
branch
from
0f78d5a to
20044b6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 76.28% 76.37% +0.09%
==========================================
Files 21 21
Lines 2353 2362 +9
==========================================
+ Hits 1795 1804 +9
Misses 461 461
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
spe-dev
force-pushed
the
fix_packets_lost
branch
from
9968c8c to
0f78d5a
Compare
pionbot
force-pushed
the
fix_packets_lost
branch
from
0f78d5a to
5b22425
Compare
The total number of packets lost is a signed number and can be negative to communicate multiple transmissions of a packet.
Sean-Der
force-pushed
the
fix_packets_lost
branch
from
5b22425 to
5f40168
Compare
Member
|
Changing this will cause the following packages to not compile, so I think it is worth a
|
Member
|
We could potentially get around the breaking change by adding two helper methods to ReceiptionReport: func (*ReceptionReport) SetTotalLostInt32(totalLost int32) {...}
func (*ReceptionReport) TotalLostInt32() int32 {...}2c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TotalLost field is defined as an uint32. But RFC 3550 mentions that the field can be set with negative values as it's a int24. To avoid bit manipulation in each apps that use pion, this PR do the job during Marshal/Unmarshal funcs.
Ref: https://datatracker.ietf.org/doc/html/rfc3550 Section 6.4 & A.3